Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: gdb.objc/objcdecode.exp test error..
Date: Thu, 24 Sep 2009 17:41:00 -0000	[thread overview]
Message-ID: <20090924174150.GD2112@adacore.com> (raw)
In-Reply-To: <20090924164115.GA2112@adacore.com>

> 	* gdb.objc/objcdecode.exp: Additional objc tests for 8343.

And finally, review of the changes for this testcase.

> +gdb_test "set multiple-symbols all" ".*" "setup multiple-symbols all"

The .* is unnecessary, gdb_test already does that for you.  But harmless.
Still, I'd remove it, though, since we expect no output at all.

> +set name "can hit multiply defined breakpoint on function after main"
> +gdb_continue_to_breakpoint "function multipleDef"
> +set name "can hit multiply defined breakpoint on objc method after main"
> +gdb_continue_to_breakpoint "method multipleDef"

name seems unusued in these two cases? Or did you mean to use it in
the call to gdb_continue_to_breakpoint?

> +setup_kfail "*-*-*" gdb/8343
> +gdb_run_cmd
> +gdb_test "" \
> +"Breakpoint \[0-9\]+, multipleDef \\\(\\\) at .*" \
> +"can hit multiply defined breakpoint on function before main"

I would put the setup_kfail after the gdb_run_cmd, if you don't mind.
That way, it's clear that the kfail is for the gdb_test, not the
gdb_run_cmd.

Pre-approved with the changes requested.

A big thank you for providing the testcases. I'm sure they will help
lots in the future when we actually tackle this issue.

-- 
Joel


  parent reply	other threads:[~2009-09-24 17:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06  1:31 Matt Rice
2009-03-06 17:33 ` Joel Brobecker
2009-03-06 19:13   ` Pedro Alves
2009-03-07 12:07     ` Matt Rice
2009-03-08 14:16       ` Matt Rice
2009-03-09  2:10         ` Matt Rice
2009-09-11 11:43           ` Matt Rice
2009-09-24  0:53             ` Joel Brobecker
2009-09-24  8:24               ` Matt Rice
2009-09-24 18:28                 ` Tom Tromey
2009-09-24 22:07                   ` Matt Rice
2009-09-24 22:29                 ` Matt Rice
2009-09-24 22:51                   ` Matt Rice
2009-09-25  4:03               ` Matt Rice
2009-10-13  0:44               ` Tom Tromey
2009-10-14  1:59                 ` Joel Brobecker
2009-09-23 23:13         ` Joel Brobecker
2009-09-24  6:48           ` Matt Rice
2009-09-24 16:41             ` Joel Brobecker
2009-09-24 17:31               ` Joel Brobecker
2009-09-24 17:41               ` Joel Brobecker [this message]
2009-09-24 16:52             ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090924174150.GD2112@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox