From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4497 invoked by alias); 24 Sep 2009 17:41:59 -0000 Received: (qmail 4484 invoked by uid 22791); 24 Sep 2009 17:41:58 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Sep 2009 17:41:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AD7792BAB67 for ; Thu, 24 Sep 2009 13:41:52 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Ah6zMofQAkSX for ; Thu, 24 Sep 2009 13:41:52 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7454F2BAAEF for ; Thu, 24 Sep 2009 13:41:52 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2973BF593C; Thu, 24 Sep 2009 10:41:50 -0700 (PDT) Date: Thu, 24 Sep 2009 17:41:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: gdb.objc/objcdecode.exp test error.. Message-ID: <20090924174150.GD2112@adacore.com> References: <8ba6bed40903051731s41c9183aha18af51113f3c0ea@mail.gmail.com> <20090306173345.GI3744@adacore.com> <200903061913.43419.pedro@codesourcery.com> <8ba6bed40903070407q3e91f0ffs6fc67b2b9c329081@mail.gmail.com> <8ba6bed40903080716k3fbeb56t5605aef1864b26a3@mail.gmail.com> <20090923231317.GA18470@adacore.com> <8ba6bed40909232348j47027093of7a2bafb8120e5ce@mail.gmail.com> <20090924164115.GA2112@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090924164115.GA2112@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00749.txt.bz2 > * gdb.objc/objcdecode.exp: Additional objc tests for 8343. And finally, review of the changes for this testcase. > +gdb_test "set multiple-symbols all" ".*" "setup multiple-symbols all" The .* is unnecessary, gdb_test already does that for you. But harmless. Still, I'd remove it, though, since we expect no output at all. > +set name "can hit multiply defined breakpoint on function after main" > +gdb_continue_to_breakpoint "function multipleDef" > +set name "can hit multiply defined breakpoint on objc method after main" > +gdb_continue_to_breakpoint "method multipleDef" name seems unusued in these two cases? Or did you mean to use it in the call to gdb_continue_to_breakpoint? > +setup_kfail "*-*-*" gdb/8343 > +gdb_run_cmd > +gdb_test "" \ > +"Breakpoint \[0-9\]+, multipleDef \\\(\\\) at .*" \ > +"can hit multiply defined breakpoint on function before main" I would put the setup_kfail after the gdb_run_cmd, if you don't mind. That way, it's clear that the kfail is for the gdb_test, not the gdb_run_cmd. Pre-approved with the changes requested. A big thank you for providing the testcases. I'm sure they will help lots in the future when we actually tackle this issue. -- Joel