From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: gdb.objc/objcdecode.exp test error..
Date: Fri, 06 Mar 2009 17:33:00 -0000 [thread overview]
Message-ID: <20090306173345.GI3744@adacore.com> (raw)
In-Reply-To: <8ba6bed40903051731s41c9183aha18af51113f3c0ea@mail.gmail.com>
Matt,
(interesting email address :-)
As far as I can tell, the copyright assignment papers you filed with
the FSF only covers GNUSTEP. We can take this change in as a "tiny
change", but it would be better if you had a proper copyright assignment
at least for GDB (I suggest to assign any past and future changes
to any GNU software and be done with it, but I understand if you prefer
to choose a more limited list of projects). Once you are covered for
GDB, let us know and we can add you to the list of contributors that
have write-after-approval access to the GDB repository.
> i should probably come up with another test for multiple-symbols all,
> so neither failure gets forgotten, but i'll have to learn more about
> dejagnu before i'm able to do that.
That would be very nice if you could add these extra tests.
It makes sense to test the behaviour in the "ask" case, but we really
ought to try to test the default case as well.
It shouldn't be very hard: Try it by hand, and then add a gdb_test
with the expected output. The expected output regular expression
can be a bit hairy because you have to escape backslashes, but
otherwise, it's fairly simple to program by copy/paste.
> +2009-03-05 Matt Rice <ratmice@gmail.com>
> +
> + * gdb.objc/objcdecode.exp: Set the multiple symbols found behaviour
> + to ask.
In the meantime, this looks reasonable to me. I can check it in
for you if you'd like.
--
Joel
next prev parent reply other threads:[~2009-03-06 17:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 1:31 Matt Rice
2009-03-06 17:33 ` Joel Brobecker [this message]
2009-03-06 19:13 ` Pedro Alves
2009-03-07 12:07 ` Matt Rice
2009-03-08 14:16 ` Matt Rice
2009-03-09 2:10 ` Matt Rice
2009-09-11 11:43 ` Matt Rice
2009-09-24 0:53 ` Joel Brobecker
2009-09-24 8:24 ` Matt Rice
2009-09-24 18:28 ` Tom Tromey
2009-09-24 22:07 ` Matt Rice
2009-09-24 22:29 ` Matt Rice
2009-09-24 22:51 ` Matt Rice
2009-09-25 4:03 ` Matt Rice
2009-10-13 0:44 ` Tom Tromey
2009-10-14 1:59 ` Joel Brobecker
2009-09-23 23:13 ` Joel Brobecker
2009-09-24 6:48 ` Matt Rice
2009-09-24 16:41 ` Joel Brobecker
2009-09-24 17:31 ` Joel Brobecker
2009-09-24 17:41 ` Joel Brobecker
2009-09-24 16:52 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090306173345.GI3744@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox