From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4151 invoked by alias); 6 Mar 2009 17:33:56 -0000 Received: (qmail 4142 invoked by uid 22791); 6 Mar 2009 17:33:55 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Mar 2009 17:33:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A07522BABE8 for ; Fri, 6 Mar 2009 12:33:51 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id a-BTN0NfDHhq for ; Fri, 6 Mar 2009 12:33:51 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6C7B72BABE6 for ; Fri, 6 Mar 2009 12:33:51 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BEFF5E7ACD; Fri, 6 Mar 2009 09:33:45 -0800 (PST) Date: Fri, 06 Mar 2009 17:33:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: gdb.objc/objcdecode.exp test error.. Message-ID: <20090306173345.GI3744@adacore.com> References: <8ba6bed40903051731s41c9183aha18af51113f3c0ea@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ba6bed40903051731s41c9183aha18af51113f3c0ea@mail.gmail.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org X-SW-Source: 2009-03/txt/msg00081.txt.bz2 Matt, (interesting email address :-) As far as I can tell, the copyright assignment papers you filed with the FSF only covers GNUSTEP. We can take this change in as a "tiny change", but it would be better if you had a proper copyright assignment at least for GDB (I suggest to assign any past and future changes to any GNU software and be done with it, but I understand if you prefer to choose a more limited list of projects). Once you are covered for GDB, let us know and we can add you to the list of contributors that have write-after-approval access to the GDB repository. > i should probably come up with another test for multiple-symbols all, > so neither failure gets forgotten, but i'll have to learn more about > dejagnu before i'm able to do that. That would be very nice if you could add these extra tests. It makes sense to test the behaviour in the "ask" case, but we really ought to try to test the default case as well. It shouldn't be very hard: Try it by hand, and then add a gdb_test with the expected output. The expected output regular expression can be a bit hairy because you have to escape backslashes, but otherwise, it's fairly simple to program by copy/paste. > +2009-03-05 Matt Rice > + > + * gdb.objc/objcdecode.exp: Set the multiple symbols found behaviour > + to ask. In the meantime, this looks reasonable to me. I can check it in for you if you'd like. -- Joel