Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: [RFA/commit] s/nquery/query/ in record.c (was "Re: Another 	proposal for frontends and queries.")
Date: Tue, 22 Sep 2009 22:49:00 -0000	[thread overview]
Message-ID: <20090922224925.GH8910@adacore.com> (raw)
In-Reply-To: <F7CE05678329534C957159168FA70DEC51564F0AD8@EUSAACMS0703.eamcs.ericsson.se>

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

It seems that the discussion regarding a short-term fix has died,
so I'm assuming that Hui is OK for now with changing nquery to query.

Here is a patch that I tested on x86_64-linux, no regression.
Will commit in the head and 7.0 branches in a couple of days pending
objections.

MarcK, did you write a patch like this one, a while ago. You should
get credit for it if you did.

2009-09-22  Joel Brobecker  <brobecker@adacore.com>

        * record.c (record_open, record_store_registers, record_xfer_partial):
        Replace calls to nquery by calls to query.

-- 
Joel

[-- Attachment #2: record.diff --]
[-- Type: text/x-diff, Size: 2448 bytes --]

commit c27c19686fafd2850ca2401280cf043ecbb60c48
Author: Joel Brobecker <brobecker@adacore.com>
Date:   Tue Sep 22 15:03:52 2009 -0700

        * record.c (record_open, record_store_registers, record_xfer_partial):
        Replace calls to nquery by calls to query.

diff --git a/gdb/record.c b/gdb/record.c
index 8ad5bf8..c675e34 100644
--- a/gdb/record.c
+++ b/gdb/record.c
@@ -497,7 +497,7 @@ record_open (char *name, int from_tty)
   /* Check if record target is already running.  */
   if (current_target.to_stratum == record_stratum)
     {
-      if (!nquery
+      if (!query
 	  (_("Process record target already running, do you want to delete "
 	     "the old record log?")))
 	return;
@@ -1029,15 +1029,15 @@ record_store_registers (struct target_ops *ops, struct regcache *regcache,
 	  /* Let user choose if he wants to write register or not.  */
 	  if (regno < 0)
 	    n =
-	      nquery (_("Because GDB is in replay mode, changing the "
-			"value of a register will make the execution "
-			"log unusable from this point onward.  "
-			"Change all registers?"));
+	      query (_("Because GDB is in replay mode, changing the "
+		       "value of a register will make the execution "
+		       "log unusable from this point onward.  "
+		       "Change all registers?"));
 	  else
 	    n =
-	      nquery (_("Because GDB is in replay mode, changing the value "
-			"of a register will make the execution log unusable "
-			"from this point onward.  Change register %s?"),
+	      query (_("Because GDB is in replay mode, changing the value "
+		       "of a register will make the execution log unusable "
+		       "from this point onward.  Change register %s?"),
 		      gdbarch_register_name (get_regcache_arch (regcache),
 					       regno));
 
@@ -1085,9 +1085,9 @@ record_xfer_partial (struct target_ops *ops, enum target_object object,
       if (RECORD_IS_REPLAY)
 	{
 	  /* Let user choose if he wants to write memory or not.  */
-	  if (!nquery (_("Because GDB is in replay mode, writing to memory "
-		         "will make the execution log unusable from this "
-		         "point onward.  Write memory at address %s?"),
+	  if (!query (_("Because GDB is in replay mode, writing to memory "
+		        "will make the execution log unusable from this "
+		        "point onward.  Write memory at address %s?"),
 		       paddress (target_gdbarch, offset)))
 	    error (_("Process record canceled the operation."));
 

  reply	other threads:[~2009-09-22 22:49 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14  2:38 Another proposal for frontends and queries Marc Khouzam
2009-09-14  6:45 ` Vladimir Prus
2009-09-14 13:07   ` Marc Khouzam
2009-09-14 14:09 ` Joel Brobecker
2009-09-14 14:28   ` Marc Khouzam
2009-09-14 14:48     ` Pedro Alves
2009-09-14 14:57       ` Marc Khouzam
2009-09-14 15:08       ` Joel Brobecker
2009-09-14 15:36         ` Marc Khouzam
2009-09-14 16:06           ` Joel Brobecker
2009-09-15 16:26         ` Joel Brobecker
2009-09-16  6:24           ` Hui Zhu
2009-09-16 12:38             ` Marc Khouzam
2009-09-16 13:06               ` Hui Zhu
2009-09-16 13:25                 ` Pedro Alves
2009-09-16 13:46                   ` Hui Zhu
2009-09-16 13:59                     ` Marc Khouzam
2009-09-16 14:17                       ` Hui Zhu
2009-09-16 14:26                         ` Joel Brobecker
2009-09-16 14:34                           ` Hui Zhu
2009-09-16 14:45                             ` Pedro Alves
2009-09-16 14:43                           ` Marc Khouzam
2009-09-16 18:03                         ` Tom Tromey
2009-09-16 23:36                           ` Hui Zhu
2009-09-16 23:40                             ` Joel Brobecker
2009-09-16 17:12                   ` Eli Zaretskii
2009-09-14 15:23     ` Joel Brobecker
2009-09-16 20:20     ` Tom Tromey
2009-09-16 20:35       ` Marc Khouzam
2009-09-17  0:17         ` Michael Snyder
2009-09-17  0:48           ` Marc Khouzam
2009-09-17  1:03             ` Joel Brobecker
2009-09-17  2:07               ` Marc Khouzam
2009-09-17  0:16       ` Michael Snyder
2009-09-16 20:43 ` Tom Tromey
2009-09-16 21:41   ` Joel Brobecker
2009-09-17 13:51     ` Marc Khouzam
2009-09-17 19:52       ` Tom Tromey
2009-09-18  4:59         ` Hui Zhu
2009-09-18  5:16           ` Michael Snyder
2009-09-18  9:31           ` Pedro Alves
2009-09-18 14:37             ` Joel Brobecker
2009-09-18 14:57         ` Marc Khouzam
2009-09-18 16:42           ` Tom Tromey
2009-09-22  0:46             ` Marc Khouzam
2009-09-22 22:49               ` Joel Brobecker [this message]
2009-09-23 12:45                 ` [RFA/commit] s/nquery/query/ in record.c (was "Re: Another proposal for frontends and queries.") Marc Khouzam
2009-09-24  3:05                   ` Hui Zhu
2009-09-24 17:59                 ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090922224925.GH8910@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox