From: nickrob@snap.net.nz (Nick Roberts)
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re:[MI] -stack-list-variables
Date: Sat, 19 Sep 2009 22:41:00 -0000 [thread overview]
Message-ID: <20090919224050.5DE89C164@totara> (raw)
In-Reply-To: <200909191412.37692.vladimir@codesourcery.com>
> ...The new command is called -stack-list-variables,
> and it's checked in into CVS HEAD.
I don't like this patch/commit for a couple of reasons. One reason I
proposed such a command was to move away from the loose syntax that MI
uses. In particular to move away from:
`LIST ==>'
` "[]" | "[" VALUE ( "," VALUE )* "]" | "[" RESULT ( "," RESULT )* "]" '
to
`LIST ==>'
` "[]" | "[" VALUE ( "," VALUE )* "]" '
to provide a more JSON-like syntax.
As with -stack-list-locals, the new output can give something like:
-stack-list-variables --no-values
^done,variables=[name="i",name="j",name="asdf",name="m",name="zxcv",name="qwert"]
but to keep JSON-like syntax, this needs to be:
-stack-list-variables --no-values
^done,variables=[{name="i"},{name="j"},{name="asdf"},{name="m"},{name="zxcv"},{name="qwert"}]
which leads to my second point:
Which `variables' are the arguments and which are locals?
Arguments might be a kind of local but they're not identical.
How about the format below?:
-stack-list-variables --no-values
^done,variables={args=[{name="i"},{name="j"}],
locals=[{name="asdf"},{name="m"},{name="zxcv"},{name="qwert"}]}
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2009-09-19 22:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-19 10:12 [MI] -stack-list-variables Vladimir Prus
2009-09-19 10:13 ` Vladimir Prus
2009-09-19 10:38 ` Eli Zaretskii
2009-09-19 11:15 ` Vladimir Prus
2009-09-19 15:45 ` Joel Brobecker
2009-09-19 15:46 ` Joel Brobecker
2009-09-19 22:41 ` Nick Roberts [this message]
2009-09-20 6:18 ` Vladimir Prus
2009-09-20 22:05 ` Nick Roberts
2009-09-21 5:14 ` Vladimir Prus
2009-09-21 7:13 ` Nick Roberts
2009-09-21 7:39 ` Vladimir Prus
2009-09-21 15:29 ` Joel Brobecker
2009-09-21 16:02 ` Vladimir Prus
2009-09-21 16:27 ` Joel Brobecker
2009-09-21 16:54 ` Vladimir Prus
2009-09-21 17:04 ` Tom Tromey
2009-09-21 17:17 ` Vladimir Prus
2009-09-21 17:24 ` Tom Tromey
2009-09-21 17:03 ` Marc Khouzam
2009-09-21 22:10 ` Nick Roberts
2009-09-22 5:31 ` Vladimir Prus
2009-09-22 14:50 ` Daniel Jacobowitz
2009-09-29 6:35 ` Vladimir Prus
2009-09-29 23:27 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090919224050.5DE89C164@totara \
--to=nickrob@snap.net.nz \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox