From: Joel Brobecker <brobecker@adacore.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [MI] -stack-list-variables
Date: Sat, 19 Sep 2009 15:45:00 -0000 [thread overview]
Message-ID: <20090919154525.GS8910@adacore.com> (raw)
In-Reply-To: <200909191412.37692.vladimir@codesourcery.com>
Hi,
I just noticed a couple of things while glancing at the patch...
> +/* Print a list of the local variables (including arguments) for the
> + current frame. With argument of 0, print only the names, with
^ Space missing
> + argument of 1 print also the values. */
I also found the comment a little confusing. I would probably have
said that ARGC must be 1 or an error is thown, and to see
parse_print_values for a list of valid values for ARGV[0].
(there is no comment for parse_print_value, btw).
> + if (argc != 1)
> + error (_("Usage: PRINT_VALUES"));
> +
> + frame = get_selected_frame (NULL);
> +
> + list_args_or_locals (all, parse_print_values (argv[0]), frame);
The indentation of the last couple of statements is off by one.
--
Joel
next prev parent reply other threads:[~2009-09-19 15:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-19 10:12 Vladimir Prus
2009-09-19 10:13 ` Vladimir Prus
2009-09-19 10:38 ` Eli Zaretskii
2009-09-19 11:15 ` Vladimir Prus
2009-09-19 15:45 ` Joel Brobecker [this message]
2009-09-19 15:46 ` Joel Brobecker
2009-09-19 22:41 ` -stack-list-variables Nick Roberts
2009-09-20 6:18 ` [MI] -stack-list-variables Vladimir Prus
2009-09-20 22:05 ` Nick Roberts
2009-09-21 5:14 ` Vladimir Prus
2009-09-21 7:13 ` Nick Roberts
2009-09-21 7:39 ` Vladimir Prus
2009-09-21 15:29 ` Joel Brobecker
2009-09-21 16:02 ` Vladimir Prus
2009-09-21 16:27 ` Joel Brobecker
2009-09-21 16:54 ` Vladimir Prus
2009-09-21 17:04 ` Tom Tromey
2009-09-21 17:17 ` Vladimir Prus
2009-09-21 17:24 ` Tom Tromey
2009-09-21 17:03 ` Marc Khouzam
2009-09-21 22:10 ` Nick Roberts
2009-09-22 5:31 ` Vladimir Prus
2009-09-22 14:50 ` Daniel Jacobowitz
2009-09-29 6:35 ` Vladimir Prus
2009-09-29 23:27 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090919154525.GS8910@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox