From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@vmware.com
Cc: teawater@gmail.com, brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [RFA] Make the prec support signal better[4/4] -- amd64-linux
Date: Sat, 19 Sep 2009 20:57:00 -0000 [thread overview]
Message-ID: <200909192056.n8JKuegJ015674@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <4AB53FF6.4030104@vmware.com> (message from Michael Snyder on Sat, 19 Sep 2009 13:32:54 -0700)
> Date: Sat, 19 Sep 2009 13:32:54 -0700
> From: Michael Snyder <msnyder@vmware.com>
>
> No one has commented on these for 10 days now.
> It looks to me as if you have addressed the previous comments.
Sorry, no, the diff isn't right yet.
> > +#define AMD64_LINUX_redzone 128
> > +#define AMD64_LINUX_xstate 512
> > +#define AMD64_LINUX_frame_size 560
Please make these all caps.
With that change, this should be fine.
next prev parent reply other threads:[~2009-09-19 20:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 13:29 Hui Zhu
2009-09-09 13:52 ` Mark Kettenis
2009-09-10 1:57 ` Hui Zhu
2009-09-19 20:33 ` Michael Snyder
2009-09-19 20:57 ` Mark Kettenis [this message]
2009-09-21 7:00 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909192056.n8JKuegJ015674@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox