Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: teawater@gmail.com
Cc: gdb-patches@sourceware.org, msnyder@vmware.com
Subject: Re: [RFA] Make the prec support signal better[4/4] -- amd64-linux
Date: Wed, 09 Sep 2009 13:52:00 -0000	[thread overview]
Message-ID: <200909091352.n89Dq7FG003824@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <daef60380909090629n68903846i1afc07921f30ebad@mail.gmail.com> 	(message from Hui Zhu on Wed, 9 Sep 2009 21:29:20 +0800)

> From: Hui Zhu <teawater@gmail.com>
> Date: Wed, 9 Sep 2009 21:29:20 +0800
> 
> This patch make amd64-linux support signal record.
> When signal happen, amd64_linux_record_signal will record the change.
> When the signal handler want return, new code in
> "amd64_linux_syscall_record" will record the change.
> 
> 2009-09-09  Michael Snyder  <msnyder@vmware.com>
> 	    Hui Zhu  <teawater@gmail.com>
> 
> 	* amd64-linux-tdep.c (amd64_all_but_ip_registers_record): New
> 	function.
> 	(amd64_linux_syscall_record): Call
> 	amd64_all_but_ip_registers_record if syscall is
> 	sys_rt_sigreturn.
> 	(amd64_linux_signal_stack): New enum.
> 	(amd64_linux_record_signal): New function.
> 	(amd64_linux_init_abi): Call set_gdbarch_process_record_signal.

Same comments, questions as the i386 counterpart.  In addition to
that:

> - record_regs:
> +record_regs:

Not sure if it is spelled out in the coding standards, but emacs' GNU
mode seems to insist on the space you're removing.

Also, looking at this diff it seems there are lots of Linux-specific
constants and functions that have an amd64_ prefix instead of an
amd64_linux_ prefix.  In particular the system call numbers.  Please
fix that (in a seperate diff).


  reply	other threads:[~2009-09-09 13:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-09 13:29 Hui Zhu
2009-09-09 13:52 ` Mark Kettenis [this message]
2009-09-10  1:57   ` Hui Zhu
2009-09-19 20:33     ` Michael Snyder
2009-09-19 20:57       ` Mark Kettenis
2009-09-21  7:00         ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909091352.n89Dq7FG003824@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox