From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66652-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4387 invoked by alias); 9 Sep 2009 13:52:17 -0000
Received: (qmail 4340 invoked by uid 22791); 9 Sep 2009 13:52:16 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Sep 2009 13:52:12 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n89Dq7Xq032118; 	Wed, 9 Sep 2009 15:52:07 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n89Dq7FG003824; 	Wed, 9 Sep 2009 15:52:07 +0200 (CEST)
Date: Wed, 09 Sep 2009 13:52:00 -0000
Message-Id: <200909091352.n89Dq7FG003824@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: teawater@gmail.com
CC: gdb-patches@sourceware.org, msnyder@vmware.com
In-reply-to: <daef60380909090629n68903846i1afc07921f30ebad@mail.gmail.com> 	(message from Hui Zhu on Wed, 9 Sep 2009 21:29:20 +0800)
Subject: Re: [RFA] Make the prec support signal better[4/4] -- amd64-linux
References:  <daef60380909090629n68903846i1afc07921f30ebad@mail.gmail.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00247.txt.bz2

> From: Hui Zhu <teawater@gmail.com>
> Date: Wed, 9 Sep 2009 21:29:20 +0800
> 
> This patch make amd64-linux support signal record.
> When signal happen, amd64_linux_record_signal will record the change.
> When the signal handler want return, new code in
> "amd64_linux_syscall_record" will record the change.
> 
> 2009-09-09  Michael Snyder  <msnyder@vmware.com>
> 	    Hui Zhu  <teawater@gmail.com>
> 
> 	* amd64-linux-tdep.c (amd64_all_but_ip_registers_record): New
> 	function.
> 	(amd64_linux_syscall_record): Call
> 	amd64_all_but_ip_registers_record if syscall is
> 	sys_rt_sigreturn.
> 	(amd64_linux_signal_stack): New enum.
> 	(amd64_linux_record_signal): New function.
> 	(amd64_linux_init_abi): Call set_gdbarch_process_record_signal.

Same comments, questions as the i386 counterpart.  In addition to
that:

> - record_regs:
> +record_regs:

Not sure if it is spelled out in the coding standards, but emacs' GNU
mode seems to insist on the space you're removing.

Also, looking at this diff it seems there are lots of Linux-specific
constants and functions that have an amd64_ prefix instead of an
amd64_linux_ prefix.  In particular the system call numbers.  Please
fix that (in a seperate diff).