From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7874 invoked by alias); 19 Sep 2009 20:57:36 -0000 Received: (qmail 7866 invoked by uid 22791); 19 Sep 2009 20:57:35 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 19 Sep 2009 20:57:29 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n8JKuffa021401; Sat, 19 Sep 2009 22:56:41 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n8JKuegJ015674; Sat, 19 Sep 2009 22:56:40 +0200 (CEST) Date: Sat, 19 Sep 2009 20:57:00 -0000 Message-Id: <200909192056.n8JKuegJ015674@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: msnyder@vmware.com CC: teawater@gmail.com, brobecker@adacore.com, gdb-patches@sourceware.org In-reply-to: <4AB53FF6.4030104@vmware.com> (message from Michael Snyder on Sat, 19 Sep 2009 13:32:54 -0700) Subject: Re: [RFA] Make the prec support signal better[4/4] -- amd64-linux References: <200909091352.n89Dq7FG003824@brahms.sibelius.xs4all.nl> <4AB53FF6.4030104@vmware.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00638.txt.bz2 > Date: Sat, 19 Sep 2009 13:32:54 -0700 > From: Michael Snyder > > No one has commented on these for 10 days now. > It looks to me as if you have addressed the previous comments. Sorry, no, the diff isn't right yet. > > +#define AMD64_LINUX_redzone 128 > > +#define AMD64_LINUX_xstate 512 > > +#define AMD64_LINUX_frame_size 560 Please make these all caps. With that change, this should be fine.