Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Hui Zhu <teawater@gmail.com>,
		gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Make the prec support signal better[0/4]
Date: Sat, 12 Sep 2009 01:02:00 -0000	[thread overview]
Message-ID: <20090912010230.GU20694@adacore.com> (raw)
In-Reply-To: <4AAAEE45.3070504@vmware.com>

> No no, I've already contributed more than my share of ugliness
> to the world.  PROTOTYPES removed.   ;-)

OK (thanks!)! It looks much more readable, now. However, you forgot to
update the functions that have no argument (it should be "(void)"
rather than "()"). I promise this is the last thing I'm seeing! :-).

The rest looks great to me.

-- 
Joel


  reply	other threads:[~2009-09-12  1:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-09 13:28 Hui Zhu
2009-09-10 19:43 ` Michael Snyder
2009-09-10 23:30   ` Joel Brobecker
2009-09-11  0:30     ` Michael Snyder
2009-09-11 20:07     ` Michael Snyder
2009-09-11 23:43       ` Joel Brobecker
2009-09-12  0:43         ` Michael Snyder
2009-09-12  1:02           ` Joel Brobecker [this message]
2009-09-13  0:29             ` Michael Snyder
2009-09-11 21:52     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090912010230.GU20694@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox