From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10179 invoked by alias); 12 Sep 2009 01:02:41 -0000 Received: (qmail 10090 invoked by uid 22791); 12 Sep 2009 01:02:41 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 12 Sep 2009 01:02:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E48142BABDA; Fri, 11 Sep 2009 21:02:34 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id nDOZoOrqh7Pw; Fri, 11 Sep 2009 21:02:34 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 677F62BAB8D; Fri, 11 Sep 2009 21:02:34 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id EDEC5F589B; Fri, 11 Sep 2009 18:02:30 -0700 (PDT) Date: Sat, 12 Sep 2009 01:02:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: Hui Zhu , gdb-patches ml Subject: Re: [RFA] Make the prec support signal better[0/4] Message-ID: <20090912010230.GU20694@adacore.com> References: <4AA95648.10605@vmware.com> <20090910232952.GP20694@adacore.com> <4AAAAD82.50300@vmware.com> <20090911234317.GT20694@adacore.com> <4AAAEE45.3070504@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AAAEE45.3070504@vmware.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00355.txt.bz2 > No no, I've already contributed more than my share of ugliness > to the world. PROTOTYPES removed. ;-) OK (thanks!)! It looks much more readable, now. However, you forgot to update the functions that have no argument (it should be "(void)" rather than "()"). I promise this is the last thing I'm seeing! :-). The rest looks great to me. -- Joel