From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Michael Snyder <msnyder@vmware.com>, Hui Zhu <teawater@gmail.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Make the prec support signal better[0/4]
Date: Fri, 11 Sep 2009 21:52:00 -0000 [thread overview]
Message-ID: <m3ws45du9e.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090910232952.GP20694@adacore.com> (Joel Brobecker's message of "Thu, 10 Sep 2009 16:29:52 -0700")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> if [target_info exists gdb,nosignals] {
>> verbose "Skipping sigall-reverse.exp because of nosignals."
>> continue
>> }
Joel> I wonder why we do a continue here, whereas we do a return elsewhere:
>> if ![target_info exists gdb,can_reverse] {
>> return
>> }
Joel> I wish we had a cookbook for writing testcases, I always forget what
Joel> we're supposed to do :-(. Anyone knows if this is significant?
Internally, all Tcl functions return a result code. It has been a
while, but ISTR the codes are something like: OK, ERROR, CONTINUE,
BREAK, RETURN. This allows execution control without the use of
longjmp... the "return" function returns RETURN, continue returns
CONTINUE, etc; then a surrounding loop function examines the code to
decide what to do next.
I presume, without looking, that the "source" command probably treats
CONTINUE, BREAK, and RETURN equivalently.
That is, there is likely no difference. "return" is clearer, though.
I agree it would be good to have a test case cookbook, and guidelines.
Tom
prev parent reply other threads:[~2009-09-11 21:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 13:28 Hui Zhu
2009-09-10 19:43 ` Michael Snyder
2009-09-10 23:30 ` Joel Brobecker
2009-09-11 0:30 ` Michael Snyder
2009-09-11 20:07 ` Michael Snyder
2009-09-11 23:43 ` Joel Brobecker
2009-09-12 0:43 ` Michael Snyder
2009-09-12 1:02 ` Joel Brobecker
2009-09-13 0:29 ` Michael Snyder
2009-09-11 21:52 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ws45du9e.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox