Re: [RFA] Implement -break-commands

[Vladimir Prus <vladimir@codesourcery.com>]

On Monday 27 July 2009 Marc Khouzam wrote:

> > -----Original Message-----
> > From: gdb-patches-owner@sourceware.org 
> > [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Vladimir Prus
> > Sent: Monday, July 27, 2009 5:03 AM
> > To: gdb-patches@sources.redhat.com
> > Subject: [RFA] Implement -break-commands
> > 
> > 
> > The below patches implement MI -break-commands. As the name implies,
> > it's the same as CLI 'commands'. There are two patches: one
> > refactors CLI 'commands' for easier reuse, and the second actually
> > adds -break-commands. The patches mostly were derived from Apple
> > branch, and then adjusted for CVS HEAD. One functional change I've
> > made is that '-break-commands <number>' does not report the list
> > of currently set commands -- since -break-info already prints his
> > information, it does not seem necessary to add another way. I've
> > also added a test and docs.
> 
> Nice addition.
> 
> > 
> > The parts of this patch that are not MI are:
> > 1. Slight refactoring of cli/cli-script.c
> > 2. Slight refactoring of breakpoint.c
> > 
> > I'd appreciate if somebody could review them.
> > 
> > Eli, there's also doc change here, comments appreciated.
> 
> I noticed the example in the doc is missing the breakpoint number:
> 
> 	> +-break-command "print v" "continue"
> 
> Unless it is optional?

It's a doc bug -- thanks for noticing. I've fixed it in my patch tree.

- Volodya