From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24178 invoked by alias); 27 Jul 2009 16:00:49 -0000 Received: (qmail 24100 invoked by uid 22791); 27 Jul 2009 16:00:47 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Jul 2009 16:00:40 +0000 Received: (qmail 4799 invoked from network); 27 Jul 2009 16:00:37 -0000 Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Jul 2009 16:00:37 -0000 From: Vladimir Prus To: "Marc Khouzam" Subject: Re: [RFA] Implement -break-commands Date: Mon, 27 Jul 2009 16:17:00 -0000 User-Agent: KMail/1.11.90 (Linux/2.6.24-24-generic; KDE/4.2.90; i686; svn-979530; 2009-06-10) Cc: gdb-patches@sources.redhat.com References: <200907271303.13335.vladimir@codesourcery.com> <6D19CA8D71C89C43A057926FE0D4ADAA07C69282@ecamlmw720.eamcs.ericsson.se> In-Reply-To: <6D19CA8D71C89C43A057926FE0D4ADAA07C69282@ecamlmw720.eamcs.ericsson.se> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200907272000.38076.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00648.txt.bz2 On Monday 27 July 2009 Marc Khouzam wrote: > > -----Original Message----- > > From: gdb-patches-owner@sourceware.org > > [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Vladimir Prus > > Sent: Monday, July 27, 2009 5:03 AM > > To: gdb-patches@sources.redhat.com > > Subject: [RFA] Implement -break-commands > > > > > > The below patches implement MI -break-commands. As the name implies, > > it's the same as CLI 'commands'. There are two patches: one > > refactors CLI 'commands' for easier reuse, and the second actually > > adds -break-commands. The patches mostly were derived from Apple > > branch, and then adjusted for CVS HEAD. One functional change I've > > made is that '-break-commands ' does not report the list > > of currently set commands -- since -break-info already prints his > > information, it does not seem necessary to add another way. I've > > also added a test and docs. > > Nice addition. > > > > > The parts of this patch that are not MI are: > > 1. Slight refactoring of cli/cli-script.c > > 2. Slight refactoring of breakpoint.c > > > > I'd appreciate if somebody could review them. > > > > Eli, there's also doc change here, comments appreciated. > > I noticed the example in the doc is missing the breakpoint number: > > > +-break-command "print v" "continue" > > Unless it is optional? It's a doc bug -- thanks for noticing. I've fixed it in my patch tree. - Volodya