Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Implement -break-commands
Date: Thu, 30 Jul 2009 16:57:00 -0000	[thread overview]
Message-ID: <m37hxqrwf8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <200907301023.45893.vladimir@codesourcery.com> (Vladimir Prus's message of "Thu\, 30 Jul 2009 10\:23\:45 +0400")

>>>>> "Volodya" == Vladimir Prus <vladimir@codesourcery.com> writes:

Volodya> This revision addresses all the comments above, except that
Volodya> request for 'closure' pointer to read_command_lines_1 if
Volodya> addressed by a comment saying why we don't do that.

There still isn't a header comment on read_next_line.  Just something
like "helper function for use with recurse_read_control_structure" would
be fine.  This is ok with the addition of a comment.

thanks,
Tom


  reply	other threads:[~2009-07-30 16:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-27 16:00 Vladimir Prus
2009-07-27 16:08 ` Marc Khouzam
2009-07-27 16:17   ` Vladimir Prus
2009-07-27 18:49 ` Tom Tromey
2009-07-27 17:38   ` Vladimir Prus
2009-07-29 21:08     ` Tom Tromey
2009-07-30  7:54   ` Vladimir Prus
2009-07-30 16:57     ` Tom Tromey [this message]
2009-08-03 12:40       ` Vladimir Prus
2009-07-30 21:22     ` Eli Zaretskii
2009-08-03 12:42       ` Vladimir Prus
2009-08-03 18:22         ` Eli Zaretskii
2009-07-27 18:56 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37hxqrwf8.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=vladimir@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox