From: Joel Brobecker <brobecker@adacore.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA Darwin v2]: Add push_dummy_call for i386
Date: Thu, 16 Jul 2009 19:28:00 -0000 [thread overview]
Message-ID: <20090716190715.GA7232@adacore.com> (raw)
In-Reply-To: <20090706073517.GA77238@Macintosh-2.local>
> 2009-07-06 Tristan Gingold <gingold@adacore.com>
>
> * i386-darwin-tdep.c (i386_m128_p): New function.
> (i386_darwin_arg_type_alignment): Ditto.
> (i386_darwin_push_dummy_call): Ditto.
> (i386_darwin_init_abi): Define Darwin specific push_dummy_call.
> Adjust long_double size. Adjust pc offset in setjump buffer.
This looks OK to me.
> +static int
> +i386_m128_p (struct type *type)
> +{
> + return TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR (type)
> + && TYPE_LENGTH (type) == 16;
> +}
Just one tiny comment: The GNU Coding Standard likes it when we use
parens around the returned expression in this case, even if it is
unecessary. It helps automatic formatting. Would you mind rewriting
it as follow:
return (TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR
&& TYPE_LENGTH (type) == 16);
?
--
Joel
next prev parent reply other threads:[~2009-07-16 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 9:45 Tristan Gingold
2009-07-16 19:28 ` Joel Brobecker [this message]
2009-08-10 9:35 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090716190715.GA7232@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox