Re: [RFA Darwin v2]: Add push_dummy_call for i386

[Tristan Gingold <gingold@adacore.com>]

On Jul 16, 2009, at 9:07 PM, Joel Brobecker wrote:

>> 2009-07-06  Tristan Gingold  <gingold@adacore.com>
>>
>> 	* i386-darwin-tdep.c (i386_m128_p): New function.
>> 	(i386_darwin_arg_type_alignment): Ditto.
>> 	(i386_darwin_push_dummy_call): Ditto.
>> 	(i386_darwin_init_abi): Define Darwin specific push_dummy_call.
>> 	Adjust long_double size.  Adjust pc offset in setjump buffer.
>
> This looks OK to me.
>
>> +static int
>> +i386_m128_p (struct type *type)
>> +{
>> +  return TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR (type)
>> +    && TYPE_LENGTH (type) == 16;
>> +}
>
> Just one tiny comment: The GNU Coding Standard likes it when we use
> parens around the returned expression in this case, even if it is
> unecessary. It helps automatic formatting. Would you mind rewriting
> it as follow:
>
>   return (TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR
>           && TYPE_LENGTH (type) == 16);

Thanks, committed with this change.

tristan.