From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25930 invoked by alias); 10 Aug 2009 09:33:33 -0000 Received: (qmail 25919 invoked by uid 22791); 10 Aug 2009 09:33:32 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Aug 2009 09:33:21 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 44BB92901BE; Mon, 10 Aug 2009 11:33:19 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZnbzvAFX03sb; Mon, 10 Aug 2009 11:33:18 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 95D8A29018B; Mon, 10 Aug 2009 11:33:18 +0200 (CEST) Cc: gdb-patches@sourceware.org Message-Id: <17E984BC-5CFA-4190-9000-2174FC99B3B2@adacore.com> From: Tristan Gingold To: Joel Brobecker In-Reply-To: <20090716190715.GA7232@adacore.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: [RFA Darwin v2]: Add push_dummy_call for i386 Date: Mon, 10 Aug 2009 09:35:00 -0000 References: <20090706073517.GA77238@Macintosh-2.local> <20090716190715.GA7232@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00140.txt.bz2 On Jul 16, 2009, at 9:07 PM, Joel Brobecker wrote: >> 2009-07-06 Tristan Gingold >> >> * i386-darwin-tdep.c (i386_m128_p): New function. >> (i386_darwin_arg_type_alignment): Ditto. >> (i386_darwin_push_dummy_call): Ditto. >> (i386_darwin_init_abi): Define Darwin specific push_dummy_call. >> Adjust long_double size. Adjust pc offset in setjump buffer. > > This looks OK to me. > >> +static int >> +i386_m128_p (struct type *type) >> +{ >> + return TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR (type) >> + && TYPE_LENGTH (type) == 16; >> +} > > Just one tiny comment: The GNU Coding Standard likes it when we use > parens around the returned expression in this case, even if it is > unecessary. It helps automatic formatting. Would you mind rewriting > it as follow: > > return (TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR > && TYPE_LENGTH (type) == 16); Thanks, committed with this change. tristan.