From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19405 invoked by alias); 16 Jul 2009 19:07:26 -0000 Received: (qmail 19396 invoked by uid 22791); 16 Jul 2009 19:07:26 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Jul 2009 19:07:20 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0E0232BAB1F; Thu, 16 Jul 2009 15:07:18 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id SdhrkT-SZeQs; Thu, 16 Jul 2009 15:07:17 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C2A902BAACF; Thu, 16 Jul 2009 15:07:17 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 58A12F58D8; Thu, 16 Jul 2009 12:07:15 -0700 (PDT) Date: Thu, 16 Jul 2009 19:28:00 -0000 From: Joel Brobecker To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: Re: [RFA Darwin v2]: Add push_dummy_call for i386 Message-ID: <20090716190715.GA7232@adacore.com> References: <20090706073517.GA77238@Macintosh-2.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090706073517.GA77238@Macintosh-2.local> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00409.txt.bz2 > 2009-07-06 Tristan Gingold > > * i386-darwin-tdep.c (i386_m128_p): New function. > (i386_darwin_arg_type_alignment): Ditto. > (i386_darwin_push_dummy_call): Ditto. > (i386_darwin_init_abi): Define Darwin specific push_dummy_call. > Adjust long_double size. Adjust pc offset in setjump buffer. This looks OK to me. > +static int > +i386_m128_p (struct type *type) > +{ > + return TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR (type) > + && TYPE_LENGTH (type) == 16; > +} Just one tiny comment: The GNU Coding Standard likes it when we use parens around the returned expression in this case, even if it is unecessary. It helps automatic formatting. Would you mind rewriting it as follow: return (TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR && TYPE_LENGTH (type) == 16); ? -- Joel