Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: tromey@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: varobj_get_type cleanup
Date: Tue, 07 Jul 2009 08:46:00 -0000	[thread overview]
Message-ID: <200907071246.36895.vladimir@codesourcery.com> (raw)
In-Reply-To: <m3hbxx7r0i.fsf@fleche.redhat.com>

[-- Attachment #1: Type: Text/Plain, Size: 528 bytes --]

On Tuesday 30 June 2009 Tom Tromey wrote:

> >>>>> "Vladimir" == Vladimir Prus <vladimir@codesourcery.com> writes:
> 
> Vladimir> I've checked in the below obvious cleanup.
> 
> Vladimir> +#include "typeprint.h"
> 
> FYI, this doesn't declare anything of interest.
> 
> type_to_string is declared, strangely, in value.h.
> (I would have expected gdbtypes.h, myself.)

Boo. I don't really understand why a function defined in
typeprint.c is declared in random headers ;-) I've checked
in the below obvious cleanup.

- Volodya




[-- Attachment #2: include.diff --]
[-- Type: text/x-patch, Size: 918 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.10693
diff -u -p -r1.10693 ChangeLog
--- ChangeLog	7 Jul 2009 07:47:19 -0000	1.10693
+++ ChangeLog	7 Jul 2009 08:46:07 -0000
@@ -1,3 +1,7 @@
+2009-07-07  Vladimir Prus  <vladimir@codesourcery.com>
+
+	* varobj.c: Remove unnecessary include.
+
 2009-07-07  Tristan Gingold  <gingold@adacore.com>
 
 	* config/i386/darwin.mh	(NATDEPFILES): Remove excServer.o.
Index: varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.139
diff -u -p -r1.139 varobj.c
--- varobj.c	2 Jul 2009 17:04:22 -0000	1.139
+++ varobj.c	7 Jul 2009 08:46:07 -0000
@@ -34,7 +34,6 @@
 #include "vec.h"
 #include "gdbthread.h"
 #include "inferior.h"
-#include "typeprint.h"
 
 #if HAVE_PYTHON
 #include "python/python.h"

      reply	other threads:[~2009-07-07  8:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30  9:25 Vladimir Prus
2009-06-30 14:09 ` Tom Tromey
2009-07-07  8:46   ` Vladimir Prus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907071246.36895.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox