From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: varobj_get_type cleanup
Date: Tue, 30 Jun 2009 09:25:00 -0000 [thread overview]
Message-ID: <200906301325.32442.vladimir@codesourcery.com> (raw)
[-- Attachment #1: Type: Text/Plain, Size: 56 bytes --]
I've checked in the below obvious cleanup.
- Volodya
[-- Attachment #2: use_type_to_string.diff --]
[-- Type: text/x-patch, Size: 1894 bytes --]
Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.10655
diff -u -p -r1.10655 ChangeLog
--- gdb/ChangeLog 29 Jun 2009 18:27:23 -0000 1.10655
+++ gdb/ChangeLog 30 Jun 2009 09:19:27 -0000
@@ -1,3 +1,7 @@
+2009-06-30 Vladimir Prus <vladimir@codesourcery.com>
+
+ * varobj.c (varobj_get_type): Use type_to_string.
+
2009-06-29 Pedro Alves <pedro@codesourcery.com>
* infrun.c (handle_inferior_event): Context switch to the new
Index: gdb/varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.136
diff -u -p -r1.136 varobj.c
--- gdb/varobj.c 29 Jun 2009 13:24:41 -0000 1.136
+++ gdb/varobj.c 30 Jun 2009 09:19:27 -0000
@@ -34,6 +34,7 @@
#include "vec.h"
#include "gdbthread.h"
#include "inferior.h"
+#include "typeprint.h"
#if HAVE_PYTHON
#include "python/python.h"
@@ -1030,29 +1031,13 @@ varobj_add_child (struct varobj *var, co
char *
varobj_get_type (struct varobj *var)
{
- struct value *val;
- struct cleanup *old_chain;
- struct ui_file *stb;
- char *thetype;
- long length;
-
/* For the "fake" variables, do not return a type. (It's type is
NULL, too.)
Do not return a type for invalid variables as well. */
if (CPLUS_FAKE_CHILD (var) || !var->root->is_valid)
return NULL;
- stb = mem_fileopen ();
- old_chain = make_cleanup_ui_file_delete (stb);
-
- /* To print the type, we simply create a zero ``struct value *'' and
- cast it to our type. We then typeprint this variable. */
- val = value_zero (var->type, not_lval);
- type_print (value_type (val), "", stb, -1);
-
- thetype = ui_file_xstrdup (stb, &length);
- do_cleanups (old_chain);
- return thetype;
+ return type_to_string (var->type);
}
/* Obtain the type of an object variable. */
next reply other threads:[~2009-06-30 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 9:25 Vladimir Prus [this message]
2009-06-30 14:09 ` Tom Tromey
2009-07-07 8:46 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906301325.32442.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox