From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24137 invoked by alias); 7 Jul 2009 08:46:46 -0000 Received: (qmail 24122 invoked by uid 22791); 7 Jul 2009 08:46:45 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Jul 2009 08:46:37 +0000 Received: (qmail 14638 invoked from network); 7 Jul 2009 08:46:36 -0000 Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Jul 2009 08:46:36 -0000 From: Vladimir Prus To: tromey@redhat.com Subject: Re: varobj_get_type cleanup Date: Tue, 07 Jul 2009 08:46:00 -0000 User-Agent: KMail/1.11.90 (Linux/2.6.24-24-generic; KDE/4.2.90; i686; svn-979530; 2009-06-10) Cc: gdb-patches@sources.redhat.com References: <200906301325.32442.vladimir@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_stwUKpLdnsbIa3h" Message-Id: <200907071246.36895.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00178.txt.bz2 --Boundary-00=_stwUKpLdnsbIa3h Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-length: 528 On Tuesday 30 June 2009 Tom Tromey wrote: > >>>>> "Vladimir" == Vladimir Prus writes: > > Vladimir> I've checked in the below obvious cleanup. > > Vladimir> +#include "typeprint.h" > > FYI, this doesn't declare anything of interest. > > type_to_string is declared, strangely, in value.h. > (I would have expected gdbtypes.h, myself.) Boo. I don't really understand why a function defined in typeprint.c is declared in random headers ;-) I've checked in the below obvious cleanup. - Volodya --Boundary-00=_stwUKpLdnsbIa3h Content-Type: text/x-patch; charset="UTF-8"; name="include.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="include.diff" Content-length: 918 Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.10693 diff -u -p -r1.10693 ChangeLog --- ChangeLog 7 Jul 2009 07:47:19 -0000 1.10693 +++ ChangeLog 7 Jul 2009 08:46:07 -0000 @@ -1,3 +1,7 @@ +2009-07-07 Vladimir Prus + + * varobj.c: Remove unnecessary include. + 2009-07-07 Tristan Gingold * config/i386/darwin.mh (NATDEPFILES): Remove excServer.o. Index: varobj.c =================================================================== RCS file: /cvs/src/src/gdb/varobj.c,v retrieving revision 1.139 diff -u -p -r1.139 varobj.c --- varobj.c 2 Jul 2009 17:04:22 -0000 1.139 +++ varobj.c 7 Jul 2009 08:46:07 -0000 @@ -34,7 +34,6 @@ #include "vec.h" #include "gdbthread.h" #include "inferior.h" -#include "typeprint.h" #if HAVE_PYTHON #include "python/python.h" --Boundary-00=_stwUKpLdnsbIa3h--