From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: Aleksandar Ristovski <aristovski@qnx.com>,
gdb-patches@sources.redhat.com
Subject: Re: [patch] gdbserver regcache fetch all regs
Date: Fri, 19 Jun 2009 15:55:00 -0000 [thread overview]
Message-ID: <20090619155537.GA23758@caradoc.them.org> (raw)
In-Reply-To: <e394668d0906190835j481d7546td6bf9b8baae9c77d@mail.gmail.com>
On Fri, Jun 19, 2009 at 08:35:13AM -0700, Doug Evans wrote:
> Hi. At first I thought "Yikes!". :-)
> But it turns out that all fetch_registers routines treat 0 and -1 equivalently.
> I wouldn't hold up this patch (it's fine with me fwiw), though I would
> change the ChangeLog entry to something like: "Use -1 instead of 0 to
> fetch all registers." since passing 0 does actually fetch all
> registers.
Agreed on all counts.
> It would be good to remove this oddity and stop the conflation of 0
> and -1, but I don't know what would break.
> We could run the testsuite and see what happens as a start.
> Does anyone know the history behind this?
Pretty sure nothing will break - since nothing else calls these
functions. I could be mistaken though.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-06-19 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 1:30 Aleksandar Ristovski
2009-06-19 15:35 ` Doug Evans
2009-06-19 15:52 ` Aleksandar Ristovski
2009-06-19 15:55 ` Daniel Jacobowitz [this message]
2009-06-19 16:09 ` Aleksandar Ristovski
2009-06-20 16:10 ` Pedro Alves
2009-06-22 19:35 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090619155537.GA23758@caradoc.them.org \
--to=drow@false.org \
--cc=aristovski@qnx.com \
--cc=dje@google.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox