From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2327 invoked by alias); 19 Jun 2009 15:55:53 -0000 Received: (qmail 2316 invoked by uid 22791); 19 Jun 2009 15:55:53 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Jun 2009 15:55:48 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 4306110D6B; Fri, 19 Jun 2009 15:55:46 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id E0A2410D65; Fri, 19 Jun 2009 15:55:45 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MHgRF-0006iP-S6; Fri, 19 Jun 2009 11:55:43 -0400 Date: Fri, 19 Jun 2009 15:55:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: Aleksandar Ristovski , gdb-patches@sources.redhat.com Subject: Re: [patch] gdbserver regcache fetch all regs Message-ID: <20090619155537.GA23758@caradoc.them.org> Mail-Followup-To: Doug Evans , Aleksandar Ristovski , gdb-patches@sources.redhat.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00509.txt.bz2 On Fri, Jun 19, 2009 at 08:35:13AM -0700, Doug Evans wrote: > Hi. At first I thought "Yikes!". :-) > But it turns out that all fetch_registers routines treat 0 and -1 equivalently. > I wouldn't hold up this patch (it's fine with me fwiw), though I would > change the ChangeLog entry to something like: "Use -1 instead of 0 to > fetch all registers." since passing 0 does actually fetch all > registers. Agreed on all counts. > It would be good to remove this oddity and stop the conflation of 0 > and -1, but I don't know what would break. > We could run the testsuite and see what happens as a start. > Does anyone know the history behind this? Pretty sure nothing will break - since nothing else calls these functions. I could be mistaken though. -- Daniel Jacobowitz CodeSourcery