From: Aleksandar Ristovski <aristovski@qnx.com>
To: gdb-patches@sources.redhat.com
Subject: [patch] gdbserver regcache fetch all regs
Date: Wed, 17 Jun 2009 01:30:00 -0000 [thread overview]
Message-ID: <h19gl1$t66$1@ger.gmane.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
Hello,
I believe this is a bug in gdbserver/regcache.c
Current code fetches regno 0 and marks regcache valid. I
believe correct should be: fetch all regs, and mark regache
valid.
Thanks,
--
Aleksandar Ristovski
QNX Software Systems
ChangeLog:
* regcache.c (get_regcache): Fetch all registers instead of
regno 0 only.
[-- Attachment #2: gdbserver-regcache.c-fetchallregs-20090616.diff --]
[-- Type: text/x-patch, Size: 556 bytes --]
Index: regcache.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/regcache.c,v
retrieving revision 1.19
diff -u -p -r1.19 regcache.c
--- regcache.c 22 Mar 2009 23:57:10 -0000 1.19
+++ regcache.c 17 Jun 2009 01:21:03 -0000
@@ -53,7 +53,7 @@ get_regcache (struct thread_info *inf, i
/* FIXME - fetch registers for INF */
if (fetch && regcache->registers_valid == 0)
{
- fetch_inferior_registers (0);
+ fetch_inferior_registers (-1);
regcache->registers_valid = 1;
}
next reply other threads:[~2009-06-17 1:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 1:30 Aleksandar Ristovski [this message]
2009-06-19 15:35 ` Doug Evans
2009-06-19 15:52 ` Aleksandar Ristovski
2009-06-19 15:55 ` Daniel Jacobowitz
2009-06-19 16:09 ` Aleksandar Ristovski
2009-06-20 16:10 ` Pedro Alves
2009-06-22 19:35 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='h19gl1$t66$1@ger.gmane.org' \
--to=aristovski@qnx.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox