Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Improve testsuite for poor expect behavior
Date: Sat, 13 Jun 2009 15:05:00 -0000	[thread overview]
Message-ID: <20090613150505.GA28157@caradoc.them.org> (raw)
In-Reply-To: <001201c9ebb1$96414b10$c2c3e130$@u-strasbg.fr>

On Sat, Jun 13, 2009 at 01:00:31AM +0200, Pierre Muller wrote:
>   For mingw32, the main problem is that
> there are extra ^M generated in the output.

Why?  ISTR that this is fixed by setting stdout/stderr to binary mode,
but I thought a patch was submitted for this ages ago... I know we're
carrying one in our tree.

>   There is a second aspect, which is mainly a problem of
> the cygwin expect: GDB run inside expect does not believe that
> they are connected to a terminal, which means that queries are
> answered by their default values.
>   A large part of the patch below is devoted to adding pattern 
> that recognize correctly the cases where a query is answered automatically.

I do not like either of these changes to the testsuite, because
they're outright wrong on other platforms.  I'd rather fix them in
GDB.  They're not limitations of expect, but of the environment in
which GDB is running.

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2009-06-13 15:05 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12 23:00 Pierre Muller
2009-06-13 14:52 ` Doug Evans
2009-06-13 15:05 ` Daniel Jacobowitz [this message]
2009-06-13 20:29   ` Pierre Muller
2009-06-13 23:55     ` 'Daniel Jacobowitz'
2009-06-14  0:25       ` Joel Brobecker
2009-06-15  7:23         ` Pierre Muller
2009-06-16 14:58           ` Joel Brobecker
2009-06-16 23:29             ` Pierre Muller
2009-06-17 13:36               ` 'Daniel Jacobowitz'
2009-06-17 14:54                 ` Joel Brobecker
2009-06-17 17:25                   ` Eli Zaretskii
2009-06-17 19:39                     ` Joel Brobecker
2009-06-18 14:38                       ` Eli Zaretskii
2009-06-18 14:59                         ` Joel Brobecker
2009-06-18 15:25                           ` Eli Zaretskii
2009-06-18 15:33                             ` Joel Brobecker
2009-06-18 15:58                               ` Samuel Bronson
2009-06-18 23:02                               ` Eli Zaretskii
2009-06-17 17:17                 ` Eli Zaretskii
2009-06-17 20:17                   ` Pierre Muller
2009-06-17 21:00                     ` Pierre Muller
2009-06-18 14:33                     ` Eli Zaretskii
2009-06-18 15:57                       ` Pierre Muller
2009-06-18 16:08                         ` Pedro Alves
2009-06-18 23:18                           ` Eli Zaretskii
2009-06-18 16:19                         ` Pedro Alves
2009-06-17 21:56                   ` Pierre Muller
2009-06-18 14:48                     ` Eli Zaretskii
2009-06-17 22:39                 ` Pierre Muller
2009-06-17 22:43                   ` 'Daniel Jacobowitz'
2009-06-17 22:54                     ` Pierre Muller
2009-06-17 23:21                       ` 'Daniel Jacobowitz'
2009-06-17 23:18                     ` Joel Brobecker
2009-06-18  6:31                       ` Mark Kettenis
2009-06-23 18:14               ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090613150505.GA28157@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox