From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8048 invoked by alias); 13 Jun 2009 15:05:18 -0000 Received: (qmail 8036 invoked by uid 22791); 13 Jun 2009 15:05:17 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 13 Jun 2009 15:05:09 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 42F3C108CE; Sat, 13 Jun 2009 15:05:07 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 2074B10554; Sat, 13 Jun 2009 15:05:06 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1MFUn3-0007Rd-6e; Sat, 13 Jun 2009 11:05:05 -0400 Date: Sat, 13 Jun 2009 15:05:00 -0000 From: Daniel Jacobowitz To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Improve testsuite for poor expect behavior Message-ID: <20090613150505.GA28157@caradoc.them.org> Mail-Followup-To: Pierre Muller , gdb-patches@sourceware.org References: <001201c9ebb1$96414b10$c2c3e130$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001201c9ebb1$96414b10$c2c3e130$@u-strasbg.fr> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00359.txt.bz2 On Sat, Jun 13, 2009 at 01:00:31AM +0200, Pierre Muller wrote: > For mingw32, the main problem is that > there are extra ^M generated in the output. Why? ISTR that this is fixed by setting stdout/stderr to binary mode, but I thought a patch was submitted for this ages ago... I know we're carrying one in our tree. > There is a second aspect, which is mainly a problem of > the cygwin expect: GDB run inside expect does not believe that > they are connected to a terminal, which means that queries are > answered by their default values. > A large part of the patch below is devoted to adding pattern > that recognize correctly the cases where a query is answered automatically. I do not like either of these changes to the testsuite, because they're outright wrong on other platforms. I'd rather fix them in GDB. They're not limitations of expect, but of the environment in which GDB is running. -- Daniel Jacobowitz CodeSourcery