From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Fixes for a couple of infrun bugs (thread hop, revert to step thread).
Date: Tue, 09 Jun 2009 19:58:00 -0000 [thread overview]
Message-ID: <20090609195807.GA25703@adacore.com> (raw)
In-Reply-To: <200905272300.28249.pedro@codesourcery.com>
[you're explaination just gave me a headache, that's what you get when
you go on vacation for too long :-)]
Coming late on this discussion:
> + /* If the stepping thread exited, then don't try reverting
> + back to it, just keep going. We need to query the target
> + in case it doesn't support thread exit events. */
I'm just wondering if it would make sense to explain why you need to do
that in the comment, or perhaps just explain what would happen if you
didn't. There is such a nice description in the body of your email, and
I'm thinking it's worth having a short summary in the code.
WDYT?
(yes, I know, I'm a comments freak)
--
Joel
next prev parent reply other threads:[~2009-06-09 19:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 22:00 Pedro Alves
2009-05-28 11:12 ` Ulrich Weigand
2009-05-28 17:20 ` Pedro Alves
2009-06-09 19:58 ` Joel Brobecker [this message]
2009-06-10 16:20 ` Pedro Alves
2009-06-10 16:37 ` Joel Brobecker
2010-08-16 17:38 ` Ulrich Weigand
2010-08-16 18:30 ` Pedro Alves
2010-08-16 18:32 ` Pedro Alves
2010-08-16 18:41 ` Ulrich Weigand
2010-08-16 18:53 ` Pedro Alves
2010-08-16 19:01 ` Ulrich Weigand
2010-09-08 18:18 ` [commit] " Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090609195807.GA25703@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox