From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19873 invoked by alias); 9 Jun 2009 19:58:24 -0000 Received: (qmail 19863 invoked by uid 22791); 9 Jun 2009 19:58:23 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Jun 2009 19:58:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B02412BAB0D; Tue, 9 Jun 2009 15:58:13 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Rao8Q9a8r38V; Tue, 9 Jun 2009 15:58:13 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 40A812BAAFC; Tue, 9 Jun 2009 15:58:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 00B01F596C; Tue, 9 Jun 2009 15:58:07 -0400 (EDT) Date: Tue, 09 Jun 2009 19:58:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Fixes for a couple of infrun bugs (thread hop, revert to step thread). Message-ID: <20090609195807.GA25703@adacore.com> References: <200905272300.28249.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200905272300.28249.pedro@codesourcery.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00237.txt.bz2 [you're explaination just gave me a headache, that's what you get when you go on vacation for too long :-)] Coming late on this discussion: > + /* If the stepping thread exited, then don't try reverting > + back to it, just keep going. We need to query the target > + in case it doesn't support thread exit events. */ I'm just wondering if it would make sense to explain why you need to do that in the comment, or perhaps just explain what would happen if you didn't. There is such a nice description in the body of your email, and I'm thinking it's worth having a short summary in the code. WDYT? (yes, I know, I'm a comments freak) -- Joel