Re: [RFA] Add comment describing the target_gdbarch global

[Joel Brobecker <brobecker@adacore.com>]

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

> > 2009-05-06  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * gdbarch.h (target_gdbarch): Add comment documenting this global.
> 
> Oops, I didn't notice that you're changing gdbarch.h directly.
> This is a generated file; you should be changing gdbarch.sh
> instead and regnerate the header file ...

(head shaking) This is really a rookie mistake. I can't believe I wasn't
paying more attention. Sorry about that!!!

Fixed thusly:

2009-05-14  Joel Brobecker  <brobecker@adacore.com>

        * gdbarch.sh: Add comment documenting the target_gdbarch global.
        gdbarch.h does NOT need to be regenerated as the corresponding
        change has already been made in a previous commit.

As explained in the ChangeLog, I reran gdbarch.sh, and it generated
the exact same files.

Checked in.

-- 
Joel

PS: I'll review your Ada patches tomorrow morning (it's getting
    too late for me, now). But thanks much for sending them.

[-- Attachment #2: gdbarch.diff --]
[-- Type: text/x-diff, Size: 1017 bytes --]

Index: gdbarch.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.sh,v
retrieving revision 1.487
diff -u -p -r1.487 gdbarch.sh
--- gdbarch.sh	30 Apr 2009 02:52:16 -0000	1.487
+++ gdbarch.sh	14 May 2009 19:13:43 -0000
@@ -850,6 +850,17 @@ struct displaced_step_closure;
 struct core_regset_section;
 
 extern struct gdbarch *current_gdbarch;
+
+/* The architecture associated with the connection to the target.
+ 
+   The architecture vector provides some information that is really
+   a property of the target: The layout of certain packets, for instance;
+   or the solib_ops vector.  Etc.  To differentiate architecture accesses
+   to per-target properties from per-thread/per-frame/per-objfile properties,
+   accesses to per-target properties should be made through target_gdbarch.
+
+   Eventually, when support for multiple targets is implemented in
+   GDB, this global should be made target-specific.  */
 extern struct gdbarch *target_gdbarch;
 EOF