From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5958 invoked by alias); 14 May 2009 19:19:57 -0000 Received: (qmail 5949 invoked by uid 22791); 14 May 2009 19:19:56 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,HK_OBFDOM X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 May 2009 19:19:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0EAEF2BACCE; Thu, 14 May 2009 15:19:49 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 33-TQOqr2Ppp; Thu, 14 May 2009 15:19:48 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D0FFD2BACC7; Thu, 14 May 2009 15:19:48 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id BCF3FF5A07; Thu, 14 May 2009 21:19:46 +0200 (CEST) Date: Thu, 14 May 2009 19:19:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Add comment describing the target_gdbarch global Message-ID: <20090514191946.GH7292@adacore.com> References: <20090507145243.GB659@adacore.com> <200905141359.n4EDxiLA017473@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline In-Reply-To: <200905141359.n4EDxiLA017473@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00308.txt.bz2 --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 943 > > 2009-05-06 Joel Brobecker > > > > * gdbarch.h (target_gdbarch): Add comment documenting this global. > > Oops, I didn't notice that you're changing gdbarch.h directly. > This is a generated file; you should be changing gdbarch.sh > instead and regnerate the header file ... (head shaking) This is really a rookie mistake. I can't believe I wasn't paying more attention. Sorry about that!!! Fixed thusly: 2009-05-14 Joel Brobecker * gdbarch.sh: Add comment documenting the target_gdbarch global. gdbarch.h does NOT need to be regenerated as the corresponding change has already been made in a previous commit. As explained in the ChangeLog, I reran gdbarch.sh, and it generated the exact same files. Checked in. -- Joel PS: I'll review your Ada patches tomorrow morning (it's getting too late for me, now). But thanks much for sending them. --3MwIy2ne0vdjdPXF Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="gdbarch.diff" Content-length: 1017 Index: gdbarch.sh =================================================================== RCS file: /cvs/src/src/gdb/gdbarch.sh,v retrieving revision 1.487 diff -u -p -r1.487 gdbarch.sh --- gdbarch.sh 30 Apr 2009 02:52:16 -0000 1.487 +++ gdbarch.sh 14 May 2009 19:13:43 -0000 @@ -850,6 +850,17 @@ struct displaced_step_closure; struct core_regset_section; extern struct gdbarch *current_gdbarch; + +/* The architecture associated with the connection to the target. + + The architecture vector provides some information that is really + a property of the target: The layout of certain packets, for instance; + or the solib_ops vector. Etc. To differentiate architecture accesses + to per-target properties from per-thread/per-frame/per-objfile properties, + accesses to per-target properties should be made through target_gdbarch. + + Eventually, when support for multiple targets is implemented in + GDB, this global should be made target-specific. */ extern struct gdbarch *target_gdbarch; EOF --3MwIy2ne0vdjdPXF--