Re: [RFA] Add comment describing the target_gdbarch global

[Joel Brobecker <brobecker@adacore.com>]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

> > 2009-05-06  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * gdbarch.h (target_gdbarch): Add comment documenting this global.
> 
> This looks fine to me.

Excellent! Thanks for double-checking. I committed the patch after
having fixed a couple of typos. Patch attached for reference, but
basically a "pre" -> "per", and a "to" -> "from".

-- 
Joel

[-- Attachment #2: comment.diff --]
[-- Type: text/x-diff, Size: 853 bytes --]

diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index 5e508d7..31c935f 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -54,6 +54,17 @@ struct displaced_step_closure;
 struct core_regset_section;
 
 extern struct gdbarch *current_gdbarch;
+
+/* The architecture associated with the connection to the target.
+ 
+   The architecture vector provides some information that is really
+   a property of the target: The layout of certain packets, for instance;
+   or the solib_ops vector.  Etc.  To differentiate architecture accesses
+   to per-target properties from per-thread/per-frame/per-objfile properties,
+   accesses to per-target properties should be made through target_gdbarch.
+
+   Eventually, when support for multiple targets is implemented in
+   GDB, this global should be made target-specific.  */
 extern struct gdbarch *target_gdbarch;