From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26445 invoked by alias); 7 May 2009 14:53:00 -0000 Received: (qmail 26414 invoked by uid 22791); 7 May 2009 14:52:58 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 May 2009 14:52:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 481032BAC44; Thu, 7 May 2009 10:52:46 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2h-+j0FeX+xE; Thu, 7 May 2009 10:52:46 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 13BFD2BAB5F; Thu, 7 May 2009 10:52:46 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 04A7EF5900; Thu, 7 May 2009 07:52:44 -0700 (PDT) Date: Thu, 07 May 2009 14:53:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Add comment describing the target_gdbarch global Message-ID: <20090507145243.GB659@adacore.com> References: <20090507005348.GA11074@adacore.com> <200905071209.n47C971e012606@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="hQiwHBbRI9kgIhsi" Content-Disposition: inline In-Reply-To: <200905071209.n47C971e012606@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00154.txt.bz2 --hQiwHBbRI9kgIhsi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 362 > > 2009-05-06 Joel Brobecker > > > > * gdbarch.h (target_gdbarch): Add comment documenting this global. > > This looks fine to me. Excellent! Thanks for double-checking. I committed the patch after having fixed a couple of typos. Patch attached for reference, but basically a "pre" -> "per", and a "to" -> "from". -- Joel --hQiwHBbRI9kgIhsi Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="comment.diff" Content-length: 853 diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h index 5e508d7..31c935f 100644 --- a/gdb/gdbarch.h +++ b/gdb/gdbarch.h @@ -54,6 +54,17 @@ struct displaced_step_closure; struct core_regset_section; extern struct gdbarch *current_gdbarch; + +/* The architecture associated with the connection to the target. + + The architecture vector provides some information that is really + a property of the target: The layout of certain packets, for instance; + or the solib_ops vector. Etc. To differentiate architecture accesses + to per-target properties from per-thread/per-frame/per-objfile properties, + accesses to per-target properties should be made through target_gdbarch. + + Eventually, when support for multiple targets is implemented in + GDB, this global should be made target-specific. */ extern struct gdbarch *target_gdbarch; --hQiwHBbRI9kgIhsi--