From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Trailing spaces in solaris_pid_to_str
Date: Tue, 12 May 2009 09:19:00 -0000 [thread overview]
Message-ID: <20090512091945.GA27497@adacore.com> (raw)
In-Reply-To: <20090501213218.4488B84890@localhost>
> Doesn't matter to me whether to check this in or not,
> just thought I'd pass it on. It is odd. Is there another reason
> for these spaces that I'm missing?
Can't figure it out. I did a bit of archeology, and this pre-dates
the public CVS.
> 2009-05-01 Doug Evans <dje@google.com>
>
> * sol-thread.c (solaris_pid_to_str): Remove trailing spaces in result.
I'm not objecting, but if it's just a visual annoyance and no one else
provides feedback, then perhaps it's better to leave things as is
(taste varies from person to person). If you need that function
elsewhere and it's causing trouble, on the other hand...
> [The spaces in "LWP %ld" are to line up the text with "Thread %ld".
> They don't bother me as much as the trailing spaces so I left them in,
> but they could just as well be deleted.]
If you do remove the trailing spaces, might as well remove the leading
ones too. There're there for formatting, so if we remove the formatting,
we might as well remove all of it (IMO).
--
Joel
next prev parent reply other threads:[~2009-05-12 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 21:32 Doug Evans
2009-05-12 9:19 ` Joel Brobecker [this message]
2009-05-12 9:39 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512091945.GA27497@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox