From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22253 invoked by alias); 12 May 2009 09:19:55 -0000 Received: (qmail 22242 invoked by uid 22791); 12 May 2009 09:19:54 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_52 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 May 2009 09:19:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 810A62BABA9; Tue, 12 May 2009 05:19:47 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cmh64+iG2MRo; Tue, 12 May 2009 05:19:47 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5028C2BABA1; Tue, 12 May 2009 05:19:47 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A869FF5905; Tue, 12 May 2009 11:19:45 +0200 (CEST) Date: Tue, 12 May 2009 09:19:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Trailing spaces in solaris_pid_to_str Message-ID: <20090512091945.GA27497@adacore.com> References: <20090501213218.4488B84890@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090501213218.4488B84890@localhost> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00241.txt.bz2 > Doesn't matter to me whether to check this in or not, > just thought I'd pass it on. It is odd. Is there another reason > for these spaces that I'm missing? Can't figure it out. I did a bit of archeology, and this pre-dates the public CVS. > 2009-05-01 Doug Evans > > * sol-thread.c (solaris_pid_to_str): Remove trailing spaces in result. I'm not objecting, but if it's just a visual annoyance and no one else provides feedback, then perhaps it's better to leave things as is (taste varies from person to person). If you need that function elsewhere and it's causing trouble, on the other hand... > [The spaces in "LWP %ld" are to line up the text with "Thread %ld". > They don't bother me as much as the trailing spaces so I left them in, > but they could just as well be deleted.] If you do remove the trailing spaces, might as well remove the leading ones too. There're there for formatting, so if we remove the formatting, we might as well remove all of it (IMO). -- Joel