Re: [RFC] Trailing spaces in solaris_pid_to_str

[Pedro Alves <pedro@codesourcery.com>]

On Tuesday 12 May 2009 10:19:45, Joel Brobecker wrote:
> > Doesn't matter to me whether to check this in or not,
> > just thought I'd pass it on.  It is odd.  Is there another reason
> > for these spaces that I'm missing?
> 
> Can't figure it out. I did a bit of archeology, and this pre-dates
> the public CVS.

Yes, if you do "info threads", it becomes dead obvious it's just for
lining up.  From PR9242, here's what one gets on solaris:

  6 Thread 3          0xdfa39657 in _swtch () from /usr/lib/libthread.so.1
  5 Thread 2 (LWP 2)  0xdfadb5a8 in _signotifywait () from /usr/lib/libc.so.1
* 4 Thread 1 (LWP 1)  main (argc=0x1, argv=0x8047874)
    at /users/pes/gdbnd/devo/gdb/testsuite/gdb.threads/pthreads.c:122
  3 LWP    3          0xdfa3a158 in _lwp_start () from /usr/lib/libthread.so.1
  2 LWP    2          0xdfadb5a8 in _signotifywait () from /usr/lib/libc.so.1
  1 LWP    1          main (argc=0x1, argv=0x8047874)
    at /users/pes/gdbnd/devo/gdb/testsuite/gdb.threads/pthreads.c:122

http://sourceware.org/bugzilla/show_bug.cgi?id=9242

Hmmm, BTW, I've fixed that PR recently; time to close it.

I've no real opinion on if the lining up is desirable or not.

> > 2009-05-01  Doug Evans  <dje@google.com>
> > 
> > 	* sol-thread.c (solaris_pid_to_str): Remove trailing spaces in result.
> 
> I'm not objecting, but if it's just a visual annoyance and no one else
> provides feedback, then perhaps it's better to leave things as is
> (taste varies from person to person). If you need that function
> elsewhere and it's causing trouble, on the other hand...
> 
> > [The spaces in "LWP    %ld" are to line up the text with "Thread %ld".
> > They don't bother me as much as the trailing spaces so I left them in,
> > but they could just as well be deleted.]
> 
> If you do remove the trailing spaces, might as well remove the leading
> ones too. There're there for formatting, so if we remove the formatting,
> we might as well remove all of it (IMO).


-- 
Pedro Alves