From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] undefined regcache_set_valid_p in remote-mips.c
Date: Mon, 16 Mar 2009 20:09:00 -0000 [thread overview]
Message-ID: <20090316200654.GA5074@caradoc.them.org> (raw)
In-Reply-To: <20090316195430.GH9576@adacore.com>
On Mon, Mar 16, 2009 at 03:54:30PM -0400, Joel Brobecker wrote:
> remote-mips.c no longer builds because of this call to regcache_set_valid_p.
> I couldn't find any trace of that routine in our ChangeLogs and I'm right
> in the middle of a rather large change in my git directory, so I didn't
> bother investigate more about this routine.
>
> I think that the routine that we want, right now, is called
> regcache_invalidate.
>
> 2009-03-16 Joel Brobecker <brobecker@adacore.com>
>
> * remote-mips.c (mips_load): Replace call to regcache_set_valid_p,
> which is undefined, by call to regcache_invalidate, which should
> do what the original author wanted to do.
>
> Does this look plausible to anyone else? I'd just like a second pair
> of eyes before I commit.
Does to me.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-03-16 20:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 20:07 Joel Brobecker
2009-03-16 20:09 ` Daniel Jacobowitz [this message]
2009-03-16 20:20 ` Pedro Alves
2009-03-16 21:19 ` Joel Brobecker
2009-03-16 21:44 ` Pedro Alves
2009-03-16 22:52 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316200654.GA5074@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox