Re: [RFA/commit] undefined regcache_set_valid_p in remote-mips.c

Pedro Alves
2009-03-16T20:09:42Z

On Monday 16 March 2009 19:54:30, Joel Brobecker wrote:
> remote-mips.c no longer builds because of this call to regcache_set_valid_p.
> I couldn't find any trace of that routine in our ChangeLogs and I'm right
> in the middle of a rather large change in my git directory, so I didn't
> bother investigate more about this routine.
>
> I think that the routine that we want, right now, is called
> regcache_invalidate.
>

I believe this was Maciej's change.

> 2009-03-16 Joel Brobecker <brobecker@adacore.com>
>
> * remote-mips.c (mips_load): Replace call to regcache_set_valid_p,
> which is undefined, by call to regcache_invalidate, which should
> do what the original author wanted to do.
>
> Does this look plausible to anyone else? I'd just like a second pair
> of eyes before I commit.
>

We have this in an internal MIPS tree:

void
regcache_invalidate (struct regcache *regcache, int regnum)
{
regcache_set_valid_p (regcache, regnum, 0);
}

So, it looks correct. This file isn't used by any FSF
configuration, BTW. I don't think I converted it to always a
thread, so it surely isn't working as is.

--
Pedro Alves