Re: [RFA/commit] undefined regcache_set_valid_p in remote-mips.c

Joel Brobecker
2009-03-16T22:22:04Z

> Ah, I knew I had been there before:
>
> http://sourceware.org/ml/gdb-patches/2008-08/msg00475.html

FWIW, I wonder what's best in this case:
(1) Leave the code as is, fearing that we might break something,
but with a strong suspicion that it is broken by an earlier change;
(2) Try fixing it blindly using visual code inspection for testing.

Short of being able to test the change ourselves, if you think as I do
that the target is very likely broken already, our best is all we have
to try to fix it.

The alternative is to make a call for help from people who care about
this target, and see if anyone is willing to help, at least with
the testing and integration. Otherwise, we could consider deprecating
this target. It's always a shame to lose a target, but what can we do
if no one if we don't have the means to keep it alive?

--
Joel