From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21104 invoked by alias); 16 Mar 2009 20:07:08 -0000 Received: (qmail 21093 invoked by uid 22791); 16 Mar 2009 20:07:04 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Mar 2009 20:06:58 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 2F097109AC; Mon, 16 Mar 2009 20:06:56 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 0B7FD105BD; Mon, 16 Mar 2009 20:06:55 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LjJ5K-0001KP-JI; Mon, 16 Mar 2009 16:06:54 -0400 Date: Mon, 16 Mar 2009 20:09:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] undefined regcache_set_valid_p in remote-mips.c Message-ID: <20090316200654.GA5074@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20090316195430.GH9576@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090316195430.GH9576@adacore.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00281.txt.bz2 On Mon, Mar 16, 2009 at 03:54:30PM -0400, Joel Brobecker wrote: > remote-mips.c no longer builds because of this call to regcache_set_valid_p. > I couldn't find any trace of that routine in our ChangeLogs and I'm right > in the middle of a rather large change in my git directory, so I didn't > bother investigate more about this routine. > > I think that the routine that we want, right now, is called > regcache_invalidate. > > 2009-03-16 Joel Brobecker > > * remote-mips.c (mips_load): Replace call to regcache_set_valid_p, > which is undefined, by call to regcache_invalidate, which should > do what the original author wanted to do. > > Does this look plausible to anyone else? I'd just like a second pair > of eyes before I commit. Does to me. -- Daniel Jacobowitz CodeSourcery