From: ppluzhnikov@google.com (Paul Pluzhnikov)
To: gdb-patches@sourceware.org
Subject: [patch] Fix unintended fall-through in dump_subexp_body_standard
Date: Tue, 03 Mar 2009 00:13:00 -0000 [thread overview]
Message-ID: <20090303001329.541223A6B9B@localhost> (raw)
Greetings,
The code currently in dump_subexp_body_standard() looks "obviously
wrong" to me, but perhaps I am missing something ...
Thanks,
--
Paul Pluzhnikov
2009-03-02 Paul Pluzhnikov <ppluzhnikov@google.com>
* expprint.c (dump_subexp_body_standard): Fix unintended fall-through.
Index: expprint.c
===================================================================
RCS file: /cvs/src/src/gdb/expprint.c,v
retrieving revision 1.35
diff -u -p -u -r1.35 expprint.c
--- expprint.c 3 Jan 2009 05:57:51 -0000 1.35
+++ expprint.c 3 Mar 2009 00:11:08 -0000
@@ -889,6 +889,7 @@ dump_subexp_body_standard (struct expres
case TERNOP_SLICE:
case TERNOP_SLICE_COUNT:
elt = dump_subexp (exp, stream, elt);
+ break;
case BINOP_ADD:
case BINOP_SUB:
case BINOP_MUL:
@@ -927,6 +928,7 @@ dump_subexp_body_standard (struct expres
case STRUCTOP_MEMBER:
case STRUCTOP_MPTR:
elt = dump_subexp (exp, stream, elt);
+ break;
case UNOP_NEG:
case UNOP_LOGICAL_NOT:
case UNOP_COMPLEMENT:
next reply other threads:[~2009-03-03 0:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 0:13 Paul Pluzhnikov [this message]
2009-03-03 0:24 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090303001329.541223A6B9B@localhost \
--to=ppluzhnikov@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox