From: Tom Tromey <tromey@redhat.com>
To: ppluzhnikov@google.com (Paul Pluzhnikov)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix unintended fall-through in dump_subexp_body_standard
Date: Tue, 03 Mar 2009 00:24:00 -0000 [thread overview]
Message-ID: <m38wnnpi6j.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090303001329.541223A6B9B@localhost> (Paul Pluzhnikov's message of "Mon\, 2 Mar 2009 16\:13\:29 -0800 \(PST\)")
>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
Paul> The code currently in dump_subexp_body_standard() looks "obviously
Paul> wrong" to me, but perhaps I am missing something ...
I think it is intended.
Paul> case TERNOP_SLICE:
Paul> case TERNOP_SLICE_COUNT:
Paul> elt = dump_subexp (exp, stream, elt);
This prints the first element of a node with 3 operands.
dump_subexp returns the index of the following element.
Then it falls through to the code to print a node with 2 operands.
Likewise the 2 operand code falls through to the 1 operand case.
Tom
prev parent reply other threads:[~2009-03-03 0:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 0:13 Paul Pluzhnikov
2009-03-03 0:24 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38wnnpi6j.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox