From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26058 invoked by alias); 3 Mar 2009 00:13:42 -0000 Received: (qmail 26047 invoked by uid 22791); 3 Mar 2009 00:13:41 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Mar 2009 00:13:35 +0000 Received: from spaceape10.eur.corp.google.com (spaceape10.eur.corp.google.com [172.28.16.144]) by smtp-out.google.com with ESMTP id n230DWqe003286 for ; Tue, 3 Mar 2009 00:13:32 GMT Received: from localhost (elbrus.mtv.corp.google.com [172.18.118.100]) by spaceape10.eur.corp.google.com with ESMTP id n230DT9W030590; Mon, 2 Mar 2009 16:13:30 -0800 Received: by localhost (Postfix, from userid 74925) id 541223A6B9B; Mon, 2 Mar 2009 16:13:29 -0800 (PST) To: gdb-patches@sourceware.org Subject: [patch] Fix unintended fall-through in dump_subexp_body_standard Message-Id: <20090303001329.541223A6B9B@localhost> Date: Tue, 03 Mar 2009 00:13:00 -0000 From: ppluzhnikov@google.com (Paul Pluzhnikov) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00024.txt.bz2 Greetings, The code currently in dump_subexp_body_standard() looks "obviously wrong" to me, but perhaps I am missing something ... Thanks, -- Paul Pluzhnikov 2009-03-02 Paul Pluzhnikov * expprint.c (dump_subexp_body_standard): Fix unintended fall-through. Index: expprint.c =================================================================== RCS file: /cvs/src/src/gdb/expprint.c,v retrieving revision 1.35 diff -u -p -u -r1.35 expprint.c --- expprint.c 3 Jan 2009 05:57:51 -0000 1.35 +++ expprint.c 3 Mar 2009 00:11:08 -0000 @@ -889,6 +889,7 @@ dump_subexp_body_standard (struct expres case TERNOP_SLICE: case TERNOP_SLICE_COUNT: elt = dump_subexp (exp, stream, elt); + break; case BINOP_ADD: case BINOP_SUB: case BINOP_MUL: @@ -927,6 +928,7 @@ dump_subexp_body_standard (struct expres case STRUCTOP_MEMBER: case STRUCTOP_MPTR: elt = dump_subexp (exp, stream, elt); + break; case UNOP_NEG: case UNOP_LOGICAL_NOT: case UNOP_COMPLEMENT: