Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: Fix most -Wmissing-prototypes -Wmissing-declarations warnings
Date: Fri, 20 Feb 2009 00:46:00 -0000	[thread overview]
Message-ID: <20090220000902.GA6428@adacore.com> (raw)
In-Reply-To: <m3ocwzzf5g.fsf@fleche.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

> The ada_typedef_print thing is a known oddity:
> 
> http://sourceware.org/ml/gdb-patches/2008-09/msg00541.html

ARGH! I missed that message :-(.  Don't hestitate to ping me
when Ada is involved, or even to take action. At worst, I can
always put it back if we later find that we need it after all.

Function removed thusly:

2009-02-19  Joel Brobecker  <brobecker@adacore.com>

        * ada-typeprint.c (ada_typedef_print): Remove.  Unused.

Tested on x86-linux by rebuilding GDB. I also grepped all files
in the sources to make sure it's not referenced anywhere else
(except ChangeLog files).

Sorry again for missing the first message.

-- 
Joel

[-- Attachment #2: unused.diff --]
[-- Type: text/plain, Size: 860 bytes --]

Index: ada-typeprint.c
===================================================================
RCS file: /cvs/src/src/gdb/ada-typeprint.c,v
retrieving revision 1.24
diff -u -p -r1.24 ada-typeprint.c
--- ada-typeprint.c	3 Jan 2009 05:57:50 -0000	1.24
+++ ada-typeprint.c	19 Feb 2009 23:57:09 -0000
@@ -114,22 +114,6 @@ decoded_type_name (struct type *type)
     }
 }
 
-
-/* Print a description of a type in the format of a
-   typedef for the current language.
-   NEW is the new name for a type TYPE.  */
-
-void
-ada_typedef_print (struct type *type, struct symbol *new,
-		   struct ui_file *stream)
-{
-   /* XXX: type_sprint */
-  fprintf_filtered (stream, "type %.*s is ",
-		    ada_name_prefix_len (SYMBOL_PRINT_NAME (new)),
-		    SYMBOL_PRINT_NAME (new));
-  type_print (type, "", stream, 1);
-}
-
 /* Print range type TYPE on STREAM.  */
 
 static void

  reply	other threads:[~2009-02-20  0:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18  4:11 Pedro Alves
2009-02-18  4:12 ` Pedro Alves
2009-02-18 14:27 ` Mark Kettenis
2009-02-18 17:34   ` Pedro Alves
2009-02-20  0:09     ` Mark Kettenis
2009-02-22 11:19       ` Pedro Alves
2009-02-18 22:54 ` Tom Tromey
2009-02-20  0:46   ` Joel Brobecker [this message]
2009-02-20  4:01     ` Tom Tromey
2009-02-20  5:43       ` Tom Tromey
2009-02-20 10:02       ` Joel Brobecker
2009-02-22  1:06   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090220000902.GA6428@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox