From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3367 invoked by alias); 20 Feb 2009 00:09:13 -0000 Received: (qmail 3358 invoked by uid 22791); 20 Feb 2009 00:09:12 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Feb 2009 00:09:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BCF512BAC03; Thu, 19 Feb 2009 19:09:06 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YB34JLN6s5jg; Thu, 19 Feb 2009 19:09:06 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7F5652BAC02; Thu, 19 Feb 2009 19:09:06 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5D221E7ACD; Thu, 19 Feb 2009 16:09:02 -0800 (PST) Date: Fri, 20 Feb 2009 00:46:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Fix most -Wmissing-prototypes -Wmissing-declarations warnings Message-ID: <20090220000902.GA6428@adacore.com> References: <200902180201.05118.pedro@codesourcery.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="9amGYk9869ThD9tj" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00400.txt.bz2 --9amGYk9869ThD9tj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 651 > The ada_typedef_print thing is a known oddity: > > http://sourceware.org/ml/gdb-patches/2008-09/msg00541.html ARGH! I missed that message :-(. Don't hestitate to ping me when Ada is involved, or even to take action. At worst, I can always put it back if we later find that we need it after all. Function removed thusly: 2009-02-19 Joel Brobecker * ada-typeprint.c (ada_typedef_print): Remove. Unused. Tested on x86-linux by rebuilding GDB. I also grepped all files in the sources to make sure it's not referenced anywhere else (except ChangeLog files). Sorry again for missing the first message. -- Joel --9amGYk9869ThD9tj Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="unused.diff" Content-length: 860 Index: ada-typeprint.c =================================================================== RCS file: /cvs/src/src/gdb/ada-typeprint.c,v retrieving revision 1.24 diff -u -p -r1.24 ada-typeprint.c --- ada-typeprint.c 3 Jan 2009 05:57:50 -0000 1.24 +++ ada-typeprint.c 19 Feb 2009 23:57:09 -0000 @@ -114,22 +114,6 @@ decoded_type_name (struct type *type) } } - -/* Print a description of a type in the format of a - typedef for the current language. - NEW is the new name for a type TYPE. */ - -void -ada_typedef_print (struct type *type, struct symbol *new, - struct ui_file *stream) -{ - /* XXX: type_sprint */ - fprintf_filtered (stream, "type %.*s is ", - ada_name_prefix_len (SYMBOL_PRINT_NAME (new)), - SYMBOL_PRINT_NAME (new)); - type_print (type, "", stream, 1); -} - /* Print range type TYPE on STREAM. */ static void --9amGYk9869ThD9tj--