From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: Fix most -Wmissing-prototypes -Wmissing-declarations warnings
Date: Wed, 18 Feb 2009 14:27:00 -0000 [thread overview]
Message-ID: <200902181012.n1IAC3ow025364@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <200902180201.05118.pedro@codesourcery.com> (message from Pedro Alves on Wed, 18 Feb 2009 02:01:04 +0000)
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Wed, 18 Feb 2009 02:01:04 +0000
>
> 3) several cases of _initialize_foo not being declared.
>
> +/* -Wmissing-prototypes */
> +extern initialize_file_ftype _initialize_cli_logging;
> +
I absolutely detest using initialize_file_ftype for this, since my
brain fails to parse this as a function prototype.
And, the GNU coding standards still demand full sentences, so in the
past I've written stuff like:
/* Provide a prototype to silence -Wmissing-prototypes. */
void _initialize_i386_tdep (void);
I don't feel too strongly about the last point, but it'd be nice to
see consistency here.
next prev parent reply other threads:[~2009-02-18 10:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 4:11 Pedro Alves
2009-02-18 4:12 ` Pedro Alves
2009-02-18 14:27 ` Mark Kettenis [this message]
2009-02-18 17:34 ` Pedro Alves
2009-02-20 0:09 ` Mark Kettenis
2009-02-22 11:19 ` Pedro Alves
2009-02-18 22:54 ` Tom Tromey
2009-02-20 0:46 ` Joel Brobecker
2009-02-20 4:01 ` Tom Tromey
2009-02-20 5:43 ` Tom Tromey
2009-02-20 10:02 ` Joel Brobecker
2009-02-22 1:06 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902181012.n1IAC3ow025364@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox