From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61760-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7226 invoked by alias); 18 Feb 2009 10:13:38 -0000
Received: (qmail 7214 invoked by uid 22791); 18 Feb 2009 10:13:37 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Feb 2009 10:13:25 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n1IAC40p024253; 	Wed, 18 Feb 2009 11:12:04 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n1IAC3ow025364; 	Wed, 18 Feb 2009 11:12:03 +0100 (CET)
Date: Wed, 18 Feb 2009 14:27:00 -0000
Message-Id: <200902181012.n1IAC3ow025364@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
CC: gdb-patches@sourceware.org
In-reply-to: <200902180201.05118.pedro@codesourcery.com> (message from Pedro 	Alves on Wed, 18 Feb 2009 02:01:04 +0000)
Subject: Re: Fix most -Wmissing-prototypes -Wmissing-declarations warnings
References:  <200902180201.05118.pedro@codesourcery.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-02/txt/msg00379.txt.bz2

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Wed, 18 Feb 2009 02:01:04 +0000
> 
>  3) several cases of _initialize_foo not being declared.
>  
> +/* -Wmissing-prototypes */
> +extern initialize_file_ftype _initialize_cli_logging;
> +

I absolutely detest using initialize_file_ftype for this, since my
brain fails to parse this as a function prototype.

And, the GNU coding standards still demand full sentences, so in the
past I've written stuff like:

/* Provide a prototype to silence -Wmissing-prototypes.  */
void _initialize_i386_tdep (void);

I don't feel too strongly about the last point, but it'd be nice to
see consistency here.