* Re: [RFA] corner case in value_from_contents_and_address
[not found] <20081127150102.GC3835@adacore.com>
@ 2009-02-03 16:53 ` Joel Brobecker
2009-02-03 17:30 ` Tom Tromey
2009-02-04 15:50 ` Jerome Guitton
0 siblings, 2 replies; 3+ messages in thread
From: Joel Brobecker @ 2009-02-03 16:53 UTC (permalink / raw)
To: Jerome Guitton, Tom Tromey; +Cc: gdb-patches
> 2008-11-27 Jerome Guitton <guitton@adacore.com>
>
> * value.c (value_from_content_and_address): Always return
> a lval_memory value, even if address is null.
Approved.
Tom,
I assume you weren't taking advantage of this undocumented anomaly...
> Index: value.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/value.c,v
> retrieving revision 1.72
> diff -u -p -r1.72 value.c
> --- value.c 26 Nov 2008 16:27:27 -0000 1.72
> +++ value.c 27 Nov 2008 15:00:31 -0000
> @@ -1704,8 +1704,7 @@ value_from_contents_and_address (struct
> else
> memcpy (value_contents_raw (v), valaddr, TYPE_LENGTH (type));
> VALUE_ADDRESS (v) = address;
> - if (address != 0)
> - VALUE_LVAL (v) = lval_memory;
> + VALUE_LVAL (v) = lval_memory;
> return v;
> }
>
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] corner case in value_from_contents_and_address
2009-02-03 16:53 ` [RFA] corner case in value_from_contents_and_address Joel Brobecker
@ 2009-02-03 17:30 ` Tom Tromey
2009-02-04 15:50 ` Jerome Guitton
1 sibling, 0 replies; 3+ messages in thread
From: Tom Tromey @ 2009-02-03 17:30 UTC (permalink / raw)
To: Joel Brobecker; +Cc: Jerome Guitton, gdb-patches
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> 2008-11-27 Jerome Guitton <guitton@adacore.com>
>> * value.c (value_from_content_and_address): Always return
>> a lval_memory value, even if address is null.
Joel> Approved.
Joel> Tom,
Joel> I assume you weren't taking advantage of this undocumented anomaly...
Nope, I don't think so.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] corner case in value_from_contents_and_address
2009-02-03 16:53 ` [RFA] corner case in value_from_contents_and_address Joel Brobecker
2009-02-03 17:30 ` Tom Tromey
@ 2009-02-04 15:50 ` Jerome Guitton
1 sibling, 0 replies; 3+ messages in thread
From: Jerome Guitton @ 2009-02-04 15:50 UTC (permalink / raw)
To: Joel Brobecker; +Cc: Tom Tromey, gdb-patches
Joel Brobecker (brobecker@adacore.com):
> > 2008-11-27 Jerome Guitton <guitton@adacore.com>
> >
> > * value.c (value_from_content_and_address): Always return
> > a lval_memory value, even if address is null.
>
> Approved.
Committed. Thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-04 15:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20081127150102.GC3835@adacore.com>
2009-02-03 16:53 ` [RFA] corner case in value_from_contents_and_address Joel Brobecker
2009-02-03 17:30 ` Tom Tromey
2009-02-04 15:50 ` Jerome Guitton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox