From: Joel Brobecker <brobecker@adacore.com>
To: Jerome Guitton <guitton@adacore.com>, Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] corner case in value_from_contents_and_address
Date: Tue, 03 Feb 2009 16:53:00 -0000 [thread overview]
Message-ID: <20090203165334.GG3964@adacore.com> (raw)
In-Reply-To: <20081127150102.GC3835@adacore.com>
> 2008-11-27 Jerome Guitton <guitton@adacore.com>
>
> * value.c (value_from_content_and_address): Always return
> a lval_memory value, even if address is null.
Approved.
Tom,
I assume you weren't taking advantage of this undocumented anomaly...
> Index: value.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/value.c,v
> retrieving revision 1.72
> diff -u -p -r1.72 value.c
> --- value.c 26 Nov 2008 16:27:27 -0000 1.72
> +++ value.c 27 Nov 2008 15:00:31 -0000
> @@ -1704,8 +1704,7 @@ value_from_contents_and_address (struct
> else
> memcpy (value_contents_raw (v), valaddr, TYPE_LENGTH (type));
> VALUE_ADDRESS (v) = address;
> - if (address != 0)
> - VALUE_LVAL (v) = lval_memory;
> + VALUE_LVAL (v) = lval_memory;
> return v;
> }
>
--
Joel
next parent reply other threads:[~2009-02-03 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081127150102.GC3835@adacore.com>
2009-02-03 16:53 ` Joel Brobecker [this message]
2009-02-03 17:30 ` Tom Tromey
2009-02-04 15:50 ` Jerome Guitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203165334.GG3964@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=guitton@adacore.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox